]> dgit.raspbian.org Git - gnome-shell.git/commit
messageTray: Close SHOWING banner when its notification is destroyed
authorSebastian Keller <skeller@gnome.org>
Sat, 25 Dec 2021 23:19:25 +0000 (00:19 +0100)
committerMarge Bot <marge-bot@gnome.org>
Wed, 5 Jan 2022 15:51:14 +0000 (15:51 +0000)
commit2801d0bfe3ebd66fec76766d05133b327e498535
tree1e532945f666ae109308f4a9e9c3ac9756a360e0
parentf04914ac15275149e04f9c1a4a3726aa2e4d35e4
messageTray: Close SHOWING banner when its notification is destroyed

Currently only banners in the SHOWN state are hidden when the underlying
notification is destroyed, but if they are in the SHOWING state, they
remain visible. Because the 'notification' member has already been set
to null when the notification got destroyed, closing the banner by
clicking on the close button, will not do anything and clicking on the
notification itself will result in an error message. For notifications
without a timeout, i.e. critical ones, this will result in an
uncloseable notification.

This can happen if the program creating a critical notification
immediately closes it again, as might happen with power notifications
from gnome-settings-daemon in some situations.

Fixes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4855
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2079>
js/ui/messageTray.js